Fix CLI bugs: conditional strptime and status_code() call#52
Merged
dannywillems merged 1 commit intomainfrom Feb 8, 2026
Merged
Fix CLI bugs: conditional strptime and status_code() call#52dannywillems merged 1 commit intomainfrom
dannywillems merged 1 commit intomainfrom
Conversation
dannywillems
force-pushed
the
fix/35-cli-bugs
branch
from
c062d3f to
d2f7658
Compare
- Move datetime.strptime() calls inside the None-check blocks to prevent TypeError when before/after are not provided - Fix response.status_code to response.status_code() (method call, not attribute access) Closes #35
dannywillems
force-pushed
the
fix/35-cli-bugs
branch
from
d2f7658 to
166c765
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datetime.strptime()inside theif before/after is not Noneblocks to preventTypeErrorwhen params are omittedresponse.status_codetoresponse.status_code()— it's a method, not an attributeTest plan
--before/--afterwithout crashingCloses #35